Issue #563 More flexible way of node renaming #817
Conversation
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
…fixes for closing/saving files on renaming. Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
stepanzharychevbroadcom
requested review from
VitGottwald,
Colin-Stone and
zFernand0
|
Also covers issue #567, it appears. |
There was a problem hiding this comment.
It works for me in all but a few instances:
- If I rename a dataset node in favorites, the node is renamed successfully. But if the node is visible in the regular list (not in favorites) the new name doesn't appear unless I refresh, or hide/reveal the node again.
- I can't rename a USS node in favorites
- If I rename a USS node which is favorited, the favorited version of the node isn't renamed. If I click on the renamed node's favorited version, it gives an error. The node is thereafter renamed in favorites, but even so I can't open it.
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
| @@ -14,12 +14,18 @@ import { createUSSTree, USSTree } from "../../../src/uss/USSTree"; | |||
| import { ZoweUSSNode } from "../../../src/uss/ZoweUSSNode"; | |||
There was a problem hiding this comment.
It looks like all changes in this file are related to formatting. Perhaps it is time, that we implement prettier #815
|
@stepanzharychevbroadcom could you look at the issues @katelynienaber found out above? |
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
Signed-off-by: Stepan Zharychev <stepan.zharychev@broadcom.com>
|
@zdmullen @katelynienaber I fixed first issue, but 2 others will need the separate ticket. Problem there is deeper than this branch, logic of USS favorite adding ignores current search pattern. So if you operate under |
|
@stepanzharychevbroadcom Thank you ^^ The first issue looks fine now. Could you link to the issue created for other 2 items? I don't want to lose them :) I will approve after this. |
…-zowe into feature/issue-563-new Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com> # Conflicts: # src/uss/ZoweUSSNode.ts
|
Posting link to opened issue for bugs 2 & 3 I found above: #911 |
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
There was a problem hiding this comment.
Issue 1 seems to be fixed and @zFernand0 has opened an issue for bugs 2 & 3, thanks guys! LGTM :D
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 51 51
Lines 5283 5283
Branches 1056 1056
=======================================
Hits 4811 4811
Misses 468 468
Partials 4 4 Continue to review full report at Codecov.
|
Is this for real? |
Nvm, it's all good now! |
|
@stepanzharychevbroadcom next time, please use the complete the template 😋 |
Proposed changes
This branch adds more flexible way of node renaming. It includes verification file status and allows to save it before rename will happen, so your changes won't be lost.
Milestone: 1.7
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewernpm run vscode:prepublishhas been executedFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...